fix: support EditorConfig comments #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec very clearly states that comments are supported. Without this fix a basic config file like the example given on the EditorConfig website will cause a crash. ``` # EditorConfig is awesome: https://EditorConfig.org # top-most EditorConfig file root = true # Unix-style newlines with a newline ending every file [*] end_of_line = lf insert_final_newline = true # ... ``` Spec: https://spec.editorconfig.org/#file-format
belav
previously approved these changes
Sep 22, 2023
| indent_style = space | ||
| indent_size = 2 | ||
| max_line_length = 10 | ||
| ; Windows-style line endings |
There was a problem hiding this comment.
I never realized this was a valid comment.
belav
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec very clearly states that comments are supported. Without this fix a basic config file like the example given on the EditorConfig website will cause a crash.
Spec: https://spec.editorconfig.org/#file-format