Add line when await precedes query expression #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domn1995
changed the title
shocklateboy92
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
LGTM!
Assuming this doesn't break any tests, I don't expect @belav will have any objections.
Will give a few days just in case and merge.
|
The changes look good, I'm just waiting on the results of running |
|
Running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @belav! I believe this PR fixes #740, but I am not sure whether my solution is optimal, nor whether it's complete. I would really appreciate your feedback and any direction if this is not adequate.
Thanks!