Break after type constraints for method declarations. It keeps things more consistent #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
requested changes
Jul 20, 2021
|
|
||
| public static ReturnType<T> MethodName<T, U>( | ||
| string reallyLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongParameterIMeanIt |
There was a problem hiding this comment.
It looks like you no longer have any tests for the "method with type constraints but no body" case.
| @@ -33,4 +51,7 @@ class ClassName<N, C, T, TT, L> | |||
| where C : class | |||
| where T : IComparable | |||
| where TT : IList<N> | |||
| where L : class, new() { } | |||
There was a problem hiding this comment.
Same here. You could just duplicate this, so we still have a "class with type constraints but no body" test, which could be different than the interface or struct case.
belav
force-pushed
the
method-generic-breaking
branch
from
c388b40 to
5a97db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #299