Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet 8 support #1013

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Dotnet 8 support #1013

merged 3 commits into from
Nov 16, 2023

Conversation

aa-dit-yuh
Copy link
Contributor

closes #1012

@shocklateboy92 shocklateboy92 enabled auto-merge (squash) November 16, 2023 03:09
@shocklateboy92 shocklateboy92 merged commit fdc1cb6 into belav:main Nov 16, 2023
3 checks passed
@belav
Copy link
Owner

belav commented Nov 16, 2023

aww @shocklateboy92 I was just working on an action that would test this!
Should we default to net8.0 instead of net7.0?

@shocklateboy92
Copy link
Collaborator

I saw your message on the discord channel, and I suppose I should have clarified:

I think we should do both! I think you should do what you were going to do, but also merge this in the meantime (so it'll be ready to release in case your tests don't work out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shocklateboy92 shocklateboy92 shocklateboy92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSharpier.MsBuild does not support DotNet 8
3 participants
@aa-dit-yuh @belav @shocklateboy92