Break long attributes consistently (#312)

closes #257
belav · Jun 16, 2021 · 9ad853f · 9ad853f
1 parent 9d59a53
commit 9ad853f
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 9 deletions.
diff --git a/Src/CSharpier.Tests/TestFiles/AttributeList/AttributeLists.cst b/Src/CSharpier.Tests/TestFiles/AttributeList/AttributeLists.cst
@@ -45,9 +45,11 @@ class ClassName
     // leading before class
     class ClassTwo { }
 
-    [BigLongAttributeWhatHappensHmmmmmmmmmmmmmmmmmmmmmmmmmmmmm(
-        "11111111111111111111111111",
-        "22222222222222222222222222")]
+    [LongAttributeWithParametersBreaking(
+        "someValue_____________",
+        "someValue_____________",
+        "someValue_____________"
+    )]
     void LongAttribute() { }
 
     public void MethodName([FromBody] SomeParameter parameter)
@@ -63,3 +65,14 @@ class ClassName
         return;
     }
 }
+
+[
+    LongAttributeWithParametersBreaking(
+        "someValue_____________",
+        "someValue_____________",
+        "someValue_____________"
+    ),
+    AnotherAttribute
+]
+public class ClassName { }
+
diff --git a/Src/CSharpier.Tests/TestFiles/ObnoxiousEdgeCases/ObnoxiousEdgeCases.cst b/Src/CSharpier.Tests/TestFiles/ObnoxiousEdgeCases/ObnoxiousEdgeCases.cst
@@ -3,7 +3,8 @@
 class ClassName
 {
     public static object? FormatValue<[DynamicallyAccessedMembers(
-            DynamicallyAccessedMemberTypes.All)]
+            DynamicallyAccessedMemberTypes.All
+        )]
         T>(T value, CultureInfo? culture = null) { }
 
     public readonly StackObjectPool<Dictionary<
@@ -57,7 +58,8 @@ class ClassName
         RemoteAuthenticationState,
         RemoteUserAccount
     > AddAccountClaimsPrincipalFactory<[DynamicallyAccessedMembers(
-            DynamicallyAccessedMemberTypes.PublicConstructors)]
+            DynamicallyAccessedMemberTypes.PublicConstructors
+        )]
         TAccountClaimsPrincipalFactory>(
         this IRemoteAuthenticationBuilder<RemoteAuthenticationState, RemoteUserAccount> builder
     ) where TAccountClaimsPrincipalFactory : AccountClaimsPrincipalFactory<RemoteUserAccount> =>

diff --git a/Src/CSharpier.Tests/TestFiles/StringLiteral/StringLiterals.cst b/Src/CSharpier.Tests/TestFiles/StringLiteral/StringLiterals.cst
@@ -1,6 +1,7 @@
 [assembly: System.Copyright(
     @"(C)""
-2009")]
+2009"
+)]
 class ClassName
 {
     private string bothLineEndingsPersist = @"\r\n \n";

diff --git a/Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/AttributeList.cs b/Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/AttributeList.cs
@@ -55,9 +55,10 @@ public static Doc Print(AttributeListSyntax node)
                                         Node.Print(attributeArgumentNode.Expression)
                                     ),
                                 Doc.Line
-                            ),
-                            Token.Print(attributeNode.ArgumentList.CloseParenToken)
-                        )
+                            )
+                        ),
+                        Doc.SoftLine,
+                        Token.Print(attributeNode.ArgumentList.CloseParenToken)
                     );
                 },
                 Doc.Line