QAT: Fix uninitialized seed in QAT compression

CpaDcRqResults have to be initialized with checksum=1 for adler32. Otherwise when error CPA_DC_OVERFLOW occurred, the next compress operation will continue on previously part-compressed data, and write invalid checksum data. When zfs decompress the compressed data, a invalid checksum will occurred and lead to openzfs#14463 Reviewed-by: Tino Reichardt <[email protected]> Reviewed-by: Weigang Li <[email protected]> Reviewed-by: Chengfei Zhu <[email protected]> Signed-off-by: naivekun <[email protected]> Closes openzfs#14632 Closes openzfs#14463
behlendorf · Mar 16, 2023 · 7032751 · 7032751
1 parent a5c469c
commit 7032751
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/module/os/linux/zfs/qat_compress.c b/module/os/linux/zfs/qat_compress.c
@@ -247,7 +247,7 @@ qat_compress_impl(qat_compress_dir_t dir, char *src, int src_len,
 	Cpa8U *buffer_meta_src = NULL;
 	Cpa8U *buffer_meta_dst = NULL;
 	Cpa32U buffer_meta_size = 0;
-	CpaDcRqResults dc_results;
+	CpaDcRqResults dc_results = {.checksum = 1};
 	CpaStatus status = CPA_STATUS_FAIL;
 	Cpa32U hdr_sz = 0;
 	Cpa32U compressed_sz;