Speculative workaround for macOS test reporting issue. #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the issue reported by #2689 is that the log line that outputs the test termination condition is being dropped by log streaming. The long term fix is to make sure that Briefcase either doesn't lose the log stream, or remove the need for log streaming entirely; but in the meantime, this approach has proven reliable (so far) in #2666.
This approach outputs the log termination condition 6 times, 0.5s apart. This gives multiple opportunities for the log message to be caught by the stream; Briefcase will stop the stream as soon as it sees one of them. The process will still stop - it will just take a couple more seconds to do so - which isn't a big problem when the test is already taking 3 minutes to run.
Fixes #2689.
PR Checklist: