Use FOR UPDATE to ensure selects conflict

beeper · Nov 5, 2023 · 4dbee68 · 4dbee68
1 parent d90cef1
commit 4dbee68
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/synapse/storage/databases/main/push_rule.py b/synapse/storage/databases/main/push_rule.py
@@ -404,7 +404,7 @@ def _add_push_rule_relative_txn(
         """
 
         if isinstance(self.database_engine, PostgresEngine):
-            sql += " FOR SHARE"
+            sql += " FOR UPDATE"
         else:
             # Annoyingly SQLite doesn't support row level locking, so lock the whole table
             self.database_engine.lock_table(txn, "push_rules")