-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
early prototype #1
base: main
Are you sure you want to change the base?
Conversation
21452f3
to
004a2bf
Compare
|
||
@Getter | ||
@SuperBuilder | ||
public class AbstractSharedBedrockChatModel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Sugesstion]
Instead of the shared model and then extending the other classes with complex inheritance. I think we could use composition (at least in the scope of our changes).
I see such an implementation with a util class here: https://github.com/beekpr/langchain4j/blob/main/langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaMessagesUtils.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anandbhaskaran that was my first thought, but then I didn't see this pattern in other libraries, I'll check maybe how other integrations are written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this PR will give us a working implementation. 🥳 Great job @michalkozminski
If this implementation is accepted or langchain implements the streaming model let's aim to sunset this fork (just to make sure that we are not stuck in an older version)
6d20783
to
5d2bc75
Compare
4ab6cbf
to
956662a
Compare
No description provided.