Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember token column not recognized #30

Closed
mitto98 opened this issue Feb 6, 2017 · 2 comments
Closed

Remember token column not recognized #30

mitto98 opened this issue Feb 6, 2017 · 2 comments

Comments

@mitto98
Copy link

mitto98 commented Feb 6, 2017

I've found a bug at row 301, i've fixed it in a local version

if col.name == 'remember_token' and typesDict[col_type] == 'string' and str(col.length) == 100:
if col.name == 'remember_token' and typesDict[col_type] == 'string' and str(col.length) == '100':
@VeeeneX
Copy link
Collaborator

VeeeneX commented Feb 7, 2017

Can you make PR please? It would be nice to have you as a contributor! :)

VeeeneX added a commit that referenced this issue Feb 20, 2017
@VeeeneX
Fix for #30
f79090a 
And possible for padding as well as small fixes
@VeeeneX VeeeneX mentioned this issue Feb 20, 2017
Merged
VeeeneX added a commit that referenced this issue Feb 20, 2017
@VeeeneX
Feature/remeber token (#39)
d8c0356 
* Updates

- Added testing Model
- Fix for #18
- Fixed issues with 'CURRENT_TIMESTAMP', 'NULL ON UPDATE CURRENT_TIMESTAMP',  'CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP'
- Check for non existing column types
- Fixed index keys, primary key is no longer included
- Added .gitignore

* Updates

- Added testing Model
- Fix for #18
- Fixed issues with 'CURRENT_TIMESTAMP', 'NULL ON UPDATE CURRENT_TIMESTAMP',  'CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP'
- Check for non existing column types
- Fixed index keys, primary key is no longer included
- Added .gitignore

* Fix for #30

And possible for padding as well as small fixes
@VeeeneX
Copy link
Collaborator

VeeeneX commented Feb 20, 2017

@mitto98 Merged closing

@VeeeneX VeeeneX closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VeeeneX @mitto98