add assertions for not matching regexes #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquadling
reviewed
Oct 4, 2018
lib/Assert/Assertion.php
Outdated
|
|
||
| if (\preg_match($pattern, $value)) { | ||
| $message = \sprintf( | ||
| static::generateMessage($message ?: 'Value "%s" does match expression.'), |
There was a problem hiding this comment.
'does match' => 'matches'
rquadling
reviewed
Oct 4, 2018
lib/Assert/Assertion.php
Outdated
|
|
||
| if (!\file_exists($value)) { | ||
| $message = \sprintf( | ||
| static::generateMessage($message ?: 'Path "%s" was expected to be exsting.'), |
There was a problem hiding this comment.
Assert::file() covers this assertion.
There was a problem hiding this comment.
assertion and test removed
rquadling
reviewed
Oct 5, 2018
README.md
Outdated
| @@ -204,6 +204,7 @@ Assertion::extensionLoaded(mixed $value); | |||
| Assertion::extensionVersion(string $extension, string $operator, mixed $version); | |||
| Assertion::false(mixed $value); | |||
| Assertion::file(string $value); | |||
| Assertion::fileExists(string $value); | |||
There was a problem hiding this comment.
Rebuild the documentation please.
|
Thank you. |
rquadling
pushed a commit
that referenced
this pull request
Oct 11, 2018
* 'master' of github.com:beberlei/assert: add assertions for existing files and not matching regexes (#261) # Conflicts: # lib/Assert/Assertion.php
rquadling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add two new assertions I want to use.