Improve performance of Assertion Chain class (#318)

beberlei · Dec 16, 2021 · fc352a3 · fc352a3
1 parent dbc94e5
commit fc352a3
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/lib/Assert/AssertionChain.php b/lib/Assert/AssertionChain.php
@@ -15,7 +15,6 @@
 namespace Assert;
 
 use LogicException;
-use ReflectionClass;
 
 /**
  * Chaining builder for assertions.
@@ -171,13 +170,12 @@ public function __call($methodName, $args): AssertionChain
             return $this;
         }
 
-        if (!\method_exists($this->assertionClassName, $methodName)) {
+        try {
+            $method = new \ReflectionMethod($this->assertionClassName, $methodName);
+        } catch (\ReflectionException $exception) {
             throw new \RuntimeException("Assertion '".$methodName."' does not exist.");
         }
 
-        $reflClass = new ReflectionClass($this->assertionClassName);
-        $method = $reflClass->getMethod($methodName);
-
         \array_unshift($args, $this->value);
         $params = $method->getParameters();
 
@@ -186,12 +184,13 @@ public function __call($methodName, $args): AssertionChain
                 continue;
             }
 
-            if ('message' == $param->getName()) {
-                $args[$idx] = $this->defaultMessage;
-            }
-
-            if ('propertyPath' == $param->getName()) {
-                $args[$idx] = $this->defaultPropertyPath;
+            switch ($param->getName()) {
+                case 'message':
+                    $args[$idx] = $this->defaultMessage;
+                    break;
+                case 'propertyPath':
+                    $args[$idx] = $this->defaultPropertyPath;
+                    break;
             }
         }