Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Teaching Merging + Email Management #326

Merged
merged 3 commits into from
Jun 30, 2024

Delete some spurious test cases

43b9c39
Select commit
Loading
Failed to load commit list.
Merged

Improve Teaching Merging + Email Management #326

Delete some spurious test cases
43b9c39
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 29, 2024 in 0s

89.24% (-0.29%) compared to c1d35ea

View this Pull Request on Codecov

89.24% (-0.29%) compared to c1d35ea

Details

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (c1d35ea) to head (43b9c39).

Files Patch % Lines
app/controllers/merge_controller.rb 85.71% 2 Missing ⚠️
app/controllers/sessions_controller.rb 80.00% 1 Missing ⚠️
app/models/teacher.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   89.52%   89.24%   -0.29%     
==========================================
  Files          28       28              
  Lines         936      958      +22     
==========================================
+ Hits          838      855      +17     
- Misses         98      103       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.