Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing disabled line wrapping for HTML #429

Merged
merged 1 commit into from
Mar 20, 2014
Merged

fixing disabled line wrapping for HTML #429

merged 1 commit into from
Mar 20, 2014

Conversation

bendman
Copy link
Contributor

@bendman bendman commented Mar 20, 2014

This pull request fixes issue #342

This is also an alternative to the pull request #423, added to maintain backwards compatibility and more complete tests (string and number values).

The check in that pull request states within it that when wrap_line_length and max_char are undefined, set wrap_line_length to undefined (even though it already is). This loses the backwards compatibility with 1.3.4 where max_char overwrote wrap_line_length if it was 0 or undefined.

This issue started because the conditional updated in commit 132fc95, although more complete (checking undefined and 0), reversed the logic from !== undefined to === undefined.

@bitwiseman bitwiseman added the bug label Mar 20, 2014
@bitwiseman bitwiseman added this to the v1.5.0 milestone Mar 20, 2014
@bitwiseman
Copy link
Member

Heh. LGTM. I can repro the problem on the website currently using your test, and I can see it passing with your change.

Thanks.

bitwiseman added a commit that referenced this pull request Mar 20, 2014
fixing disabled line wrapping for HTML
@bitwiseman bitwiseman merged commit 181b6a1 into beautifier:master Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants