fixing disabled line wrapping for HTML #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #342
This is also an alternative to the pull request #423, added to maintain backwards compatibility and more complete tests (string and number values).
The check in that pull request states within it that when
wrap_line_length
andmax_char
are undefined, setwrap_line_length
to undefined (even though it already is). This loses the backwards compatibility with 1.3.4 wheremax_char
overwrotewrap_line_length
if it was 0 or undefined.This issue started because the conditional updated in commit 132fc95, although more complete (checking undefined and 0), reversed the logic from
!== undefined
to=== undefined
.