Fix for HTML wrap_line_length #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When given a wrap_line_length of 0 without specifying a max_char then the given wrap_line_length would be overwritten by an undefined value for max_char. This results in the html beautifier ignoring the wrap_line_length of 0 given by the user and setting a default wrap_line_length of 250. Fix this by removing the check for wrap_line_length === 0 in the max_char compatibility if condition. A test is included to set the wrap_line_length to 0 and call the beautifier with a p tag containing a string which is longer than 250 characters and expecting no changes in the string.
|
Thanks! |
|
Another pull request came in that looked cleaner, took that. Thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a wrap_line_length of 0 without specifying a max_char
then the given wrap_line_length would be overwritten by an
undefined value for max_char.
This results in the html beautifier ignoring the wrap_line_length
of 0 given by the user and setting a default wrap_line_length of
250.
Fix this by removing the check for wrap_line_length === 0 in
the max_char compatibility if condition.
A test is included to set the wrap_line_length to 0 and call
the beautifier with a p tag containing a string which is longer
than 250 characters and expecting no changes in the string.
This pull request is related to issue #342