-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ci): wrong 'node' and 'deploy' workflows when using node versions…
… >14 Error: - In the `node` workflow, the `npm ci` command does not work, it needs the `package-lock.json` file to work, but this file is removed by the npm `preinstall` script. - In the `node` workflow, the version 16 check does not work because the `console.log` file is not allowed by eslint in the `EditorJson.vue` file. Solution: - Use in workflows the `npm install` command instead of `npm ci`. The `npm install` automatically runs the npm `preinstall` script which already does a clean install, removing the `node_modules` folder and the `package-lock.json` file. - Disables the `no-console` slint rule in the `EditorJson.vue` file. - Use `node` version 14 for the project, the following versions still do not work. Resolutions: - https://stackoverflow.com/a/68095189/10855837 - https://stackoverflow.com/a/53325242/10855837 - rogeriochaves/npm-force-resolutions#17 - https://www.npmjs.com/package/force-resolutions
- Loading branch information
1 parent
625a904
commit cecba97
Showing
4 changed files
with
62 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters