Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dockertest to v3.6.3 #344

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

oss92
Copy link

@oss92 oss92 commented Feb 10, 2021

Which problem is this PR solving?

Dockertest v3.3.5 ceased to work on MacOS ory/dockertest#212

Short description of the changes

Updated Dcokertest to the v3 package at version 3.6.3 to overcome the tool no longer working on darwin systems.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #344 (7686865) into master (8d8e660) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   74.25%   74.30%   +0.05%     
==========================================
  Files          65       65              
  Lines        3678     3678              
==========================================
+ Hits         2731     2733       +2     
+ Misses        841      839       -2     
  Partials      106      106              
Impacted Files Coverage Δ
component/http/middleware.go 85.50% <0.00%> (ø)
test/docker/docker.go 68.00% <ø> (ø)
component/async/kafka/simple/duration_client.go 96.36% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5520ca4...fc22134. Read the comment docs.

Copy link

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mantzas mantzas merged commit 8ca918b into beatlabs:master Feb 10, 2021
@oss92 oss92 deleted the update-docker-test branch February 10, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants