Add schedule task func #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Add Scheduled task by hour and day
test file for register
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
Co-authored-by: LeoTurnell-Ritson <[email protected]>
…-schedule-task-func
edmondac
reviewed
Aug 29, 2024
| if task.interval_minutes: | ||
| add_task(task.execute, task.interval_minutes, next_run_time=soon if task.onstart else None) | ||
| else: | ||
| add_day_task(task.execute, task.day, task.hour, next_run_time=soon if task.onstart else None) |
There was a problem hiding this comment.
I don't think a day task should run on start. I think the paradigm implies that it will only run at the specified day/time.
edmondac
reviewed
Aug 29, 2024
| last_timestamp = models.DateTimeField(null=True, blank=True) | ||
| last_success = models.BooleanField(null=True, blank=True) | ||
| last_runtime = models.FloatField(null=True, blank=True) | ||
| day = models.CharField(max_length=3, null=True, blank=True) # Day of the week ('mon', 'tue', etc.) |
There was a problem hiding this comment.
Can you validate this with choices? https://docs.djangoproject.com/en/4.2/ref/models/fields/#choices
edmondac
reviewed
Aug 29, 2024
| validators=[MinValueValidator(1), MaxValueValidator(1440)], | ||
| null=True, | ||
| blank=True | ||
| ) # 1 min to 24 hours | ||
|
|
There was a problem hiding this comment.
Can you add some validation that says you must either have day+hour OR interval_minutes?
edmondac
requested changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.