-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Oakland Raiders to Las Vegas Raiders in teamcolors dataframe #22
Comments
Thanks I will fix it as soon as I get a chance |
Thanks, @beanumber! I wrote some code to get around this for the time being but would be great if I didn't have to! |
In the same vein, the Washington Redskins ought to be renamed to be the Washington Football Team, pending their re-brand in 2022. Thanks for the great package! |
The other thing here is that the teams in the English Premier League change each year, making the EPL section of this package moot as not all current EPL teams are included. |
I'll do this Monday.
What epl teams are missing?
…On Sun, Jul 25, 2021, 3:45 PM Ben Robinson ***@***.***> wrote:
The other thing here is that the teams in the English Premier League
change each year, making the EPL section of this package moot as not all
current EPL teams are included.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIZJJLQ2WOTYOQYHSJWVZDTZRZVNANCNFSM4LWHFQ5Q>
.
|
For this year, you're missing:
Might be worthwhile adding all EPL clubs ever? I did a diff and these are the 30 others teams you're missing from all teams who've ever participated in EPL football:
|
I suppose we should just add all the teams that have ever played EPL.
…On Sun, Jul 25, 2021, 4:26 PM Ben Robinson ***@***.***> wrote:
For this year, you're missing:
- Norwich City
- Leeds United
- Brentford FC
- Aston Villa
- Wolverhampton Wanderers
Might be worthwhile adding all EPL clubs ever?
premierleague.com/clubs
I did a diff and these are the 30 others teams you're missing from all
teams who've ever participated in EPL football:
- Aston Villa
- Barnsley
- Birmingham City
- Blackburn Rovers
- Blackpool
- Bolton Wanderers
- Bradford City
- Brentford
- Cardiff City
- Charlton Athletic
- Coventry City
- Derby County
- Fulham
- Hull City
- Ipswich Town
- Leeds United
- Middlesbrough
- Norwich City
- Nottingham Forest
- Oldham Athletic
- Portsmouth
- Queens Park Rangers
- Reading
- Sheffield United
- Sheffield Wednesday
- Sunderland
- Swindon Town
- Wigan Athletic
- Wimbledon
- Wolverhampton Wanderers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIZJJLME3ONVFNTVD5CXQDTZR6SDANCNFSM4LWHFQ5Q>
.
|
See also #26 |
Just thought I'd put this request in since the base teamcolors dataset will need to change to accurately reflect the Raiders move from Oakland to Las Vegas. Thanks for this package guys!
The text was updated successfully, but these errors were encountered: