Filter transactions to only those referencing open accounts #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(And, yes, I'll fix up the failing tests if the general idea here is acceptable) |
|
I think that makes sense, I was first thinking about why filtering training data, but actually by not training such accounts they should never get suggested. |
aclindsa
force-pushed
the
filter_closed_accounts
branch
from
5a124e7
to
cf96050
Compare
|
@tarioch Okay, I believe I've now fixed up the tests. It looks like the actual tests are passing, but there appears to something going on with the build environment/dependencies that's making it fail. |
|
@yagebu I think you know that bulid environment better, can you help? |
aclindsa
force-pushed
the
filter_closed_accounts
branch
from
5d50cdf
to
c8d49f0
Compare
Add test to ensure that closed accounts are not predicted and adjust existing tests so that all desired accounts are opened.
aclindsa
force-pushed
the
filter_closed_accounts
branch
from
c8d49f0
to
8f63d1e
Compare
|
Okay, I believe I've now updated the beancount URL to point to github and appeased the linter. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick attempt at addressing #26 by only using transactions with all their postings to/from open accounts as training data.