feat(predictor): Add support for denylisting accounts #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlieberman
changed the title
|
Hi @hlieberman thank you very much for your contribution, I fixed it that for now smart-importer forces beancount < 3 and added the ci job on the PRs. Would you mind rebasing your PR so that the ci checks can run? |
There are many occasions when the training data set may include accounts which should not be predicted (e.g., accounts used for manual reconciliation of AR/AP). This feature allows the user to stop the predictor from learning these accounts, thus preventing contamination of the training set, without having to maintain a separate filtered copy of their transactions. NB: Currently, all CI runs are broken because of beancount 3.0 hitting PyPi. Manual testing with beancount<3.0.0 shows all tests passing.
|
Not sure why Github decided that a force push should close this PR there, but... reopened and rebased. :) |
yagebu
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many occasions when the training data set may include accounts which should not be predicted (e.g., accounts used for manual reconciliation of AR/AP). This feature allows the user to stop the predictor from learning these accounts, thus preventing contamination of the training set, without having to maintain a separate filtered copy of their transactions.
NB: Currently, all CI runs are broken because of beancount 3.0 hitting PyPi. Manual testing with beancount<3.0.0 shows all tests passing.