treeview #1527
Open
treeview #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagebu
requested changes
May 24, 2023
| subfiles: FileNode[]; | ||
| } | ||
|
|
||
| const zip: <A, B>(a: A[], b: B[]) => [A, B][] = <A, B>(a: A[], b: B[]) => |
There was a problem hiding this comment.
zip from d3-array could probably be used here instead
| paths: string[][], | ||
| filenodes: FileNode[] | ||
| ): [FileNode[], FolderNode[]] { | ||
| const groupBy = <T>(arr: T[], key: (i: T) => string) => |
There was a problem hiding this comment.
group from d3-array could probably be used here instead
| goToFileAndLine: (filename: string, line?: number) => void | ||
| ): [FileNode[], FolderNode[]] { | ||
| files.sort(); | ||
| const paths = files.map((file) => file.split("/")); |
There was a problem hiding this comment.
This won't work for paths on Windows...
There was a problem hiding this comment.
I guess just splitting by forward and backward slashes might be good enough for our use case here
|
Thanks for reviewing it and the comment. I hope I can take a look later this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1304 and #1137.