Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search completion issue when searching payee: field with unescaped * character #1846

Open
alexandre-janniaux opened this issue Aug 12, 2024 · 2 comments · May be fixed by #1864
Open

Search completion issue when searching payee: field with unescaped * character #1846

alexandre-janniaux opened this issue Aug 12, 2024 · 2 comments · May be fixed by #1864
Labels
bug

Comments

@alexandre-janniaux
Copy link

Hi,

I've met an issue with the search completion where it suggests an unescaped string (I'm searching for "leroy"):

image

leading to the account being empty

image

If I escape the string correctly, I do get the correct payee subacount:

image

Tested on fava-1.29.dev3+g365cd5dc
@yagebu
Copy link
Member

yagebu commented Sep 11, 2024

Yeah, I guess we need to escape those suggestions. A PR with a fix would be welcome.

@yagebu yagebu added the bug label Sep 11, 2024
@alexandre-janniaux
Copy link
Author

I've found where to modify the generated suggestion but didn't have time to actually test. I'll send the PR in the next weeks hopefully!

alexandre-janniaux added a commit to alexandre-janniaux/fava that referenced this issue Sep 20, 2024
@alexandre-janniaux
frontend: AutocompleteInput: escape * in fuzzyfinding
4ff2292 
When inserting a suggestion, the value can have invalid characters, and
in particular `*` which can easily be present on the payee: field or
narration field.

Fixes beancount#1846
alexandre-janniaux added a commit to alexandre-janniaux/fava that referenced this issue Sep 20, 2024
@alexandre-janniaux
frontend: AutocompleteInput: escape * in fuzzyfinding
a6870ad 
When inserting a suggestion, the value can have invalid characters, and
in particular `*` which can easily be present on the payee: field or
narration field.

Fixes beancount#1846
@alexandre-janniaux alexandre-janniaux linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: AutocompleteInput: escape * in fuzzyfinding (#1846) alexandre-janniaux/fava
2 participants
@alexandre-janniaux @yagebu