-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update telemetry_metrics version #63
update telemetry_metrics version #63
Conversation
f425632
to
51a93c6
Compare
mix.exs
Outdated
@@ -31,7 +31,7 @@ defmodule TelemetryMetricsPrometheus.Core.MixProject do | |||
|
|||
defp deps do | |||
[ | |||
{:telemetry_metrics, "~> 0.6"}, | |||
{:telemetry_metrics, "~> 0.6 or ~> 1.0.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{:telemetry_metrics, "~> 0.6 or ~> 1.0.0"}, | |
{:telemetry_metrics, "~> 0.6 or ~> 1.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this update. My apologies, I admittedly don't fully understand the nuances of the Elixir versioning system.
If you don't mind my asking, why is it that we are preferring 1.0 here instead of 1.0.0?
Reading through these docs I was under the impression that ~> 1.0.0
would have the desired outcome (>= 1.0.0 and < 1.1.0), whereas ~> 1.0
would allow for any version until the next major version (>= 1.0.0 and < 2.0.0).
Am I missing something? Always happy to learn more 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no breaking changes after 1.0 so we don't lock it to a minor version. That would then require publishing new packages every time a minor change is made to that library and can create dependency version conflicts for users.
51a93c6
to
b553ed4
Compare
Looks like
telemetry_metrics
got bumped to 1.0.0 with no changes, to indicate that it is stable.This PR just updates the dependency to
~> 1.0.0