-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add change invoices ability #241
Conversation
@TakteS Unfortunately, our VCRs are quite flimsy and unstable, as I'm sure you've noticed. If you managed to get this working, we'll be happy to merge. Otherwise, one of us will tackle it when we get the chance. However, I'm not sure when that will be. While we're on it, I'd like to point you in the direction of our 2.0 branch. You might be able to get your feature working more easily there. |
@begedin can it be due to different API versions? |
@lessless Somehow, the VCR tapes have "sequential" dependencies, meaning they need to be re-recorded in exact order to work. It was before my time here, but I do have an idea how it may have happened. Unfortunately, that means that in order to fix them and avoid the same problem in the future, we need to rethink the general approach used and invest a moderate amount of time to do it. |
@begedin I see. What would be an immediate solution? We do need this feature in our app :) |
@begedin I rewrote some cassettes and now all tests are passed |
@TakteS Excellent work. This is good to go, as far as I'm concerned. I just need you to squash the commits into a single commit and I can merge and release. |
@begedin can you flip the switch then, please? |
1 similar comment
@begedin Done |
Hello!
I just added functions for change invoices. My new tests are passes, but some old tests failed - I think it's because I changed
setup
block in the test file. Should I rewrite old VCR files to make it work?