Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gha #717

Merged
merged 30 commits into from
Oct 31, 2024
Merged

Update gha #717

merged 30 commits into from
Oct 31, 2024

Conversation

jsegal205
Copy link
Contributor

@jsegal205 jsegal205 commented Oct 30, 2024

fixes #716

Updates GHA workflow to not use ::set_output (as that's a deprecated command) but push to $GITHUB_OUTPUT and updates to create a comma separated list of files changed, and then explode that into a proper array when running the validation against it.

Updates validate company GHA to use https://github.com/tj-actions/changed-files to address ::set_output warning.

also bumps

  • checkout to v4 to use node lts version changelog
  • docker/setup-buildx-action to v3 to also support node lts and updates to use >> $GITHUB_OUTPUT

- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkout action only gets a single commit by default. from the docs - fetch-depth: 0 indicates all history for all branches and tags is fetched

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this action instead. It can return a list of changed company files and handles extending the depth as needed. That way we can still have fast clones.

https://github.com/tj-actions/changed-files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang you are so wise @btkostner 🙇 . I looked up get changed files github actions and got https://github.com/jitterbit/get-changed-files which has been out of date for 3+ years so I thought to go with some bash-magic I should have searched around a bit more.

But putting a positive spin on this, I learned a bunch about bash and github context in workflows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! ty for the grand suggestion again.

@jsegal205 jsegal205 marked this pull request as ready for review October 30, 2024 20:15
@jsegal205 jsegal205 requested a review from a team as a code owner October 30, 2024 20:15
@jsegal205 jsegal205 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into beam-community:main with commit ad9fe33 Oct 31, 2024
5 checks passed
@jsegal205 jsegal205 deleted the update-gha branch October 31, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ::set-output in validate_company_industry GHA
2 participants