Extract Bamboo.Phoenix #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============= We extract `Bamboo.Phoenix` to a standalone library. That makes it easier for those who want to use Bamboo but don't want to depend on Phoenix. Prior to this commit, the Phoenix dependency was optional. But now, those who want to use `Phoenix`'s rendering engine can use [`bamboo_phoenix`]. [`bamboo_phoenix`]: https://github.com/thoughtbot/bamboo_phoenix
Famkn
pushed a commit
to Famkn/bamboo
that referenced
this pull request
Aug 19, 2022
What changed? ============= We extract `Bamboo.Phoenix` to a standalone library. That makes it easier for those who want to use Bamboo but don't want to depend on Phoenix. Prior to this commit, the Phoenix dependency was optional. But now, those who want to use `Phoenix`'s rendering engine can use [`bamboo_phoenix`]. [`bamboo_phoenix`]: https://github.com/thoughtbot/bamboo_phoenix
Famkn
pushed a commit
to Famkn/bamboo
that referenced
this pull request
Aug 19, 2022
What changed? ============= We extract `Bamboo.Phoenix` to a standalone library. That makes it easier for those who want to use Bamboo but don't want to depend on Phoenix. Prior to this commit, the Phoenix dependency was optional. But now, those who want to use `Phoenix`'s rendering engine can use [`bamboo_phoenix`]. [`bamboo_phoenix`]: https://github.com/thoughtbot/bamboo_phoenix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #327
What changed?
We extract
Bamboo.Phoenixto a standalone library.That makes it easier for those who want to use Bamboo but don't want to depend on Phoenix. Prior to this commit, the Phoenix dependency was optional. But now, those who want to use
Phoenix's rendering engine can usebamboo_phoenix.