Remove deprecated code #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============= We remove deprecated code. In particular, we remove: 1. `Bamboo.Mailer.parse_opts/2`. It's been deprecated since commit [584ec63] and people can use `build_config/2` instead. 2. `TaskSupervisorStrategy.child_spec/0`. That function raises an error to notify people that the supervisor is automatically started and there's no need for setting it up. That change was introduced in [28ca48a] and removed from documentation. I think that error can now be removeed. [584ec63]: 584ec63 [28ca48a]: 28ca48a
germsvel
force-pushed
the
gv-remove-deprecated-code
branch
from
f3a6516
to
2d86a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We remove deprecated code. In particular, we remove:
Bamboo.Mailer.parse_opts/2. It's been deprecated since commit 584ec63 and people can usebuild_config/2instead.TaskSupervisorStrategy.child_spec/0. That function raises an error to notify people that the supervisor is automatically started and there's no need for setting it up. That change was introduced in 28ca48a and removed from documentation. I think that error can now be removed.