Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

pass options through to DatArchive; update readme #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garbados
Copy link
Contributor

Addresses issue #13 by passing the dat attribute of the opts parameter of indexArchive and unindexArchive to DatArchive as its second parameter. I've also updated the README to reflect this change.

@garbados
Copy link
Contributor Author

Even with this PR, you won't be able to pass options directly to Dat until this node-dat-archive PR is also merged. Even then, the interface will be a little clunky:

await webdb.indexArchive('dat://foo.com', {
  dat: {
    datOptions: { ... }
  }
})

@pfrazee
Copy link
Member

pfrazee commented Dec 31, 2017

Appreciate the PR! I agree this is a bit clunky. I was thinking about ways to clean it up and then thought, why not instantiate and pass in the DatArchive instance yourself?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants