This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
made webterm use keycodes to detect special/control keys #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the history/input handling code of the webterminal to use keycodes instead of the name of keys. Using direct keycodes means that different keyboard layouts or custom input methods will work properly. The code of the key-mapping object is taken from the `mousetrap` library which is licensed under the Apache-2.0 license.
|
Tested, works great! Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the history/input handling code of the
webterminal to use keycodes instead of the name of keys.
Using direct keycodes means that different keyboard layouts or
custom input methods will work properly.
The code of the key-mapping object is taken from the
mousetraplibrary which is licensed under the Apache-2.0 license.