Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #28 #29

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Fix #28 #29

merged 3 commits into from
Jan 28, 2022

Conversation

ericphanson
Copy link
Member

No description provided.

@ericphanson ericphanson requested a review from jrevels January 28, 2022 18:51
jrevels
jrevels approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@jrevels jrevels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Existing tests passing is enough proof for me 👍 Can you bump patch version as well? then can register once it's merged.

@ericphanson ericphanson merged commit b938543 into main Jan 28, 2022
@ericphanson ericphanson deleted the eph/endpoint branch January 28, 2022 19:40
ericphanson added a commit that referenced this pull request Jan 31, 2022
@ericphanson
Revert "Fix #28 (#29)"
91f9a6a 
This reverts commit b938543.
@ericphanson ericphanson mentioned this pull request Jun 6, 2022
Closed
@mich11 mich11 mentioned this pull request Jun 6, 2022
Merged
@jrevels jrevels mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrevels jrevels jrevels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericphanson @jrevels