-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install MNE via pip #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me and is confirmed to work via: #17 (comment).
One point regarding other changes being moved to another PR if possible. Otherwise 👍
test/runtests.jl
Outdated
# can't use `naive @test_broken` in julia 1.10+ because it now requires a bool | ||
@test_broken (info.ch_names == info["ch_names"]) isa Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-picky, but could we move this to a different PR as it doesn't pertain to installing MNE via pip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was mostly done here because without CI was broken to even do the main change, but sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see 👍
Whoops, I thought I approved it already |
fixes #17