add helper for installing sklearn #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Apr 8, 2021
ararslan
approved these changes
Apr 8, 2021
ericphanson
reviewed
Apr 9, 2021
|
|
||
| The default version is the latest stable version. | ||
| """ | ||
| function install_sklearn(version="latest"; verbose=false) |
There was a problem hiding this comment.
a late comment, but would this be better as install_sklearn!?
There was a problem hiding this comment.
It's modifying state, but not the state of any its arguments (or of any existing binding)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, this doesn't seem to be installed by default, but is needed for some functionality. I like having a default smaller install (more Julian), so I don't want to include this as part of the build process.