-
Notifications
You must be signed in to change notification settings - Fork 0
Onda Format v0.5.0 #28
Conversation
c56c533
to
36c961c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small ambiguities and some formulation tweaks, but two bigger comments
- a lot of my comments on "uh, this could be confusing for people of a certain background" doesn't need any changes in this, but might be a great candidate for something akin to an FAQ or documentation elsewhere.
- what you call "interleaved" reminds me a lot of what is called "multiplexed" in EEG formats. I haven't thought hard enough about it to know if they are actually the same or whether we're abusing DSP terms (like when non math people use "group" and "set" interchangeably), but maybe @hannahilea knows better?
But yeah, I think Arrow makes everything better.
Co-authored-by: Phillip Alday <[email protected]>
Co-authored-by: Phillip Alday <[email protected]>
@@ -50,7 +50,7 @@ This document uses the term... | |||
- ...popular distributed analytics tools (e.g. Spark, TensorFlow). | |||
- ...traditional databases (e.g. PostgresSQL, Cassandra). | |||
- ...object-based storage systems (e.g. S3, GCP Cloud Storage). | |||
- ...enable metadata, annotations etc. to be stored and processed separately from raw sample data artifacts without significant file system overhead. | |||
- ...enable metadata, annotations etc. to be stored and processed separately from raw sample data without significant communication overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even better.
I think it's basically the same IIUC. FWIW I tend to use One subtle terminology difference might arise if you e.g. multiplexed incoming streams into a chunked planar format, rather than a fully interleaved format. |
And I think some of the formats do this. 🤷 |
…w codified in column type
…econd suffix removal
…+ you almost always need both anyway
file_path
column for signals table)*.onda.annotations.arrow
and*.onda.signals.arrow
files can have arbitrary file names)float32
/float64
sample type support)file_extension
/file_options
fields with newfile_format
column to go along with the newfile_path
columnSummarizing some of the high-level impact of these changes:
*.onda.annotations.arrow
files) and signals (in*.onda.signals.arrow
files).*.onda.annotations.arrow
files, or write new signals to an existing recording w/o modifying existing files).I'm currently preparing a corresponding PR to Onda.jl 🙂