Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor batch iteration to allow for composable batching schemes #5

Open
kleinschmidt opened this issue Aug 15, 2022 · 1 comment
Open

Comments

@kleinschmidt
Copy link
Member

Currently, RandomBatches is a big chonky struct that includes three, separate things:

  • how to sample a signal from the labeled signals table
  • how to sample a window from a signal
  • how to select channels for the batch

Really, these are basically orthogonal to each other, and we could support more flexible batching specifications by allowing users to "mix and match" different ways of sampling batches with some light refactoring.

@kleinschmidt
Copy link
Member Author

From #15 (comment):

I wonder if we can (ab)use channel selectors even further, by something like samples[RandomChannels(rng, 3), :] 😄. Then instead of passing around n_channels, we could pass the selector. Oh, except you need the RNG here, not at creation time... Ok idk

@kleinschmidt kleinschmidt transferred this issue from another repository Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant