Allow convert
ing encoded samples if the element type matches
#171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, we error on
convert(::Type{Samples{A}}, ::Samples{B})
for allA
andB
if the samples are encoded. This is reasonable since we don't want to affect how the samples get decoded. However, decoding should be based on the type of the encoded samples themselves rather than of their container; a decoder shouldn't care whether the incoming data is e.g. a full matrix or a view of a matrix. Thus we can allow conversion for encoded samples provided that only the container type is affected, not the element type.cc @rebareh, who ran into this in some private Beacon code.