Bump TranscodingStreams compat #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
|
Arrow.jl with apache/arrow-julia#524 now supports the latest version of TranscodingStreams. This PR can be more easily tested now. |
|
This is great, thank you! I'm not sure why CI didn't run here though. 🤔 I'm going to try closing and reopening to see if that does it. |
ararslan
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the use of the internal
TranscodingStreams.changemode!function. This function may be broken in a future release ofTranscodingStreams. Ref: JuliaVTK/WriteVTK.jl#137TranscodingStreams v0.11 release notes: https://github.com/JuliaIO/TranscodingStreams.jl/releases/tag/v0.11.0
This release shouldn't effect this package because from what I can tell there is no use of
eof,seekend, orTranscodingStreams.Memory