Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] bump functors compat #28

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Apr 20, 2023

Backport of #27

  • I created a release-0.1 branch from e3fd92e
  • I added branch protection to it
  • Then on this branch I repeated the exact same steps as in bump functors compat #27 (update Functors 0.4, verify current tests pass, update model to have weight sharing, write it out on Fucntors 0.3, test it on Functors 0.4)

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #28 (516958c) into release-0.1 (e3fd92e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-0.1      #28   +/-   ##
============================================
  Coverage        93.87%   93.87%           
============================================
  Files                2        2           
  Lines               49       49           
============================================
  Hits                46       46           
  Misses               3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kleinschmidt
Copy link
Member

reminds me I shoudl turn on branch protection for my other backport branches 👀

@ericphanson ericphanson merged commit b746b8d into release-0.1 Apr 20, 2023
@ericphanson ericphanson deleted the eph/backport-functors-compat branch April 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants