Fixup #2
Draft
Fixup #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
commented
May 4, 2024
| "node", | ||
| dev_dependency = True, | ||
| ) | ||
| use_repo(node, "nodejs_toolchains") |
There was a problem hiding this comment.
Needed on MacOS under bzlmod to run
--extra_toolchains=@nodejs_toolchains//:linux_arm64_toolchain_target
WORKSPACE does not have this issue on transitions
gregmagolan
commented
May 4, 2024
| ], | ||
| ) | ||
|
|
||
| next_bin.next_binary( |
There was a problem hiding this comment.
Instead of a js_run_devserver binary which is for local development and won't work in a container, what you want for the image is just a js_binary which is what next_bin.next_binary is under the hood
gregmagolan
commented
May 4, 2024
| name = "image", | ||
| base = "@debian_node", | ||
| cmd = ["/app/next.js/next_js_start"], | ||
| workdir = "/app/next.js/next_js_start.runfiles/_main", |
There was a problem hiding this comment.
workdir must be set to the root of the runfiles tree in the container
gregmagolan
commented
May 4, 2024
| js_image_layer( | ||
| name = "layers", | ||
| binary = ":next_js_start", | ||
| platform = select({ |
There was a problem hiding this comment.
For transitioning the target platform to linux for for the container runtime so the image can be built locally on a mac
|
Related to aspect-build/rules_js#1530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, bzlmod node toolchains have a bug for transitions so to build the image with the correct node toolchain you need add
--extra_toolchains:That followed by
should start the webserver