Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double dispose of proxy handles #459

Merged
merged 1 commit into from
Oct 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

### Fixed
- [#459] "Proxy object was destroyed improperly! Resetting pipeline..." error appears frequently

### Changed

Expand Down
8 changes: 4 additions & 4 deletions Editor/PreviewSystem/Rendering/ProxyPipeline.cs
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,11 @@ public void Dispose()
node.Result.Dispose();
}
}
}

foreach (var proxy in _proxies.Values)
{
proxy.Dispose();
}
foreach (var proxy in _proxies.Values)
{
proxy.Dispose();
}
},
CancellationToken.None,
Expand Down
Loading