feat: ability to allow type mismatch between ProvidedParameters #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// If true, mismatched parameter types will be merged automatically | ||
| /// </summary> | ||
| public bool AllowTypeMismatch { get; set; } |
There was a problem hiding this comment.
ExpandTypeOnConflict のほうが動作がわかりやすいかも？
Comment on lines
266
to
268
| if (oldP.ParameterType == newP.ParameterType || | ||
| oldP.ParameterType != null && newP.ParameterType == null || | ||
| oldP.ParameterType != null && newP.IsAnimatorOnly) |
There was a problem hiding this comment.
この辺の&&と||の混合が少しわかりづらいので()で囲みましょう
|
CHANGELOG が AllowTypeMismatch のままだった・・・ |
|
CHANGELOGを修正しました 👍 |
|
ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProvidedParameterをマージする際、ParameterTypeが違ったら互いのParameterTypeを見て自動的に解決するかどうかを指定できるようにします。こちらで使用する機能です。
bdunderscore/modular-avatar#1174 (comment)