Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't disable sub-options when a preview plugin is disabled. #338

Merged
merged 1 commit into from
Aug 18, 2024
Merged

chore: don't disable sub-options when a preview plugin is disabled. #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#330] Preview objects are now hidden by placing them in a hidden subscene, instead of harmony patching the hierarchy.
This should improve stability in general.
- [#335] Skip preview rendering on all cameras except the scene view camera and the VRCSDK thumbnail camera.
- [#338] Don't disable sub-options when a preview plugin is disabled.

### Removed

Expand Down
4 changes: 0 additions & 4 deletions Editor/PreviewSystem/UI/PreviewPrefsUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,6 @@ internal void BindItem(ItemData itemData)
_isPass = itemData.IsPass;
_qualifiedName = itemData.QualifiedName;

var isEnabled = !itemData.IsPass ||
PreviewPrefs.instance.IsPreviewPluginEnabled(itemData.PluginQualifiedName);
_toggle.SetEnabled(isEnabled);

if (itemData.IsPass)
_toggle.AddToClassList("ndmf-pass-item");
else
Expand Down
Loading