fix: CVRAvatar prevents removal of Animator #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editor/ApplyOnPlay.cs
Outdated
Comment on lines
128
to
130
| var t_CVRAvatar = AppDomain.CurrentDomain.GetAssemblies() | ||
| .SelectMany(assembly => assembly.GetTypes()) | ||
| .FirstOrDefault(t => t.FullName == "ABI.CCK.Components.CVRAvatar"); |
There was a problem hiding this comment.
Should this be generalized to components that depend on Animator in general? That would avoid NDMF core needing to know about CVR CCK (and thus make writing a test for this behavior much easier)
There was a problem hiding this comment.
You want to enumerate the sibling components on the Animator and find out which ones have the RequireComponent attribute?
There was a problem hiding this comment.
Addressing in 85a213c
The error "Can't remove Animator because CVRAvatar (Script) depends on it" occurs in ChilloutVR avatars during the recreation of the Animator component. This is because CVRAvatar has a RequireComponent annotation for Animator. This commit fixes this issue by removing CVRAvatar first, and recreates it in the same way. Tested on ChilloutVR CCK v3.9 RELEASE
bdunderscore
force-pushed
the
cvr-cvravatar-prevents-animator-removal
branch
from
85a213c to
35ece3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error "Can't remove Animator because CVRAvatar (Script) depends on it" occurs in ChilloutVR avatars during the recreation of the Animator component.
This is because CVRAvatar has a RequireComponent annotation for Animator.
This commit fixes this issue by removing CVRAvatar first, and recreates it in the same way.
Tested on ChilloutVR CCK v3.9 RELEASE