Fix language code not recognizable due to inconsistent case #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bdunderscore
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes language code not recognizable due to inconsistent case, discovered when we (Traditional Chinese community) working on Traditional Chinese translations.
This was not a problem when there is only Simplified Chinese as there was only one language starts with
zh-, but since we have another variant now, it requires to matches the whole language code, letter by letter, not forgiving the cases.I have let the dictionary ignores the letter cases by explicit tell it to use another comparer for indexing (
StringComparer.OrdinalIgnoreCase)