Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndmf's generated animators break child animators #163

Closed
Sergster1 opened this issue Feb 8, 2024 · 2 comments · Fixed by #165
Closed

ndmf's generated animators break child animators #163

Sergster1 opened this issue Feb 8, 2024 · 2 comments · Fixed by #165

Comments

@Sergster1
Copy link

I ran into an issue with ndmf on a new Unity 2022 project where ndmf generates animators on avatars that are not using ndmf functions and causes adverse effects. You can test this with hfcRed's among us prefab as the ndmf generated animator breaks the transition from idle to run. It also appears to remove zero-weight bones that are not a physbone component.

Steps to reproduce:

  1. Create a new 2022 Avatar Project with ndmf imported via VCC
  2. Import hfcRed's among us follower prefab
  3. Enter play mode

Result:
ndmf's cloned animators conflict with the intended behavior. Bones that are zero weight and present in the Edit Scene are removed in play mode.

Expected Outcome:

Animators cloned by ndmf should function as originally intended. Unless specified, bones should not be removed from an avatar at any time.

Temporary Mitigation:
Removing ndmf from my project resolves the issue

Once I get a chance I can film a video showing the bug if you are unable to reproduce it.

@bdunderscore
Copy link
Owner

This bug appears to have been caused by some logic to recreate animators in Apply on Play added to work around another issue with Gesture Manager, and can be fixed by reversing the order in which animators are recreated. It'll be fixed in 1.6.2.

Note that cloning animators, as well as deleting empty bones, were unrelated to this issue. If you have specific problems with these behaviors, please open a new issue with a detailed description of what you're trying to achieve, and how these processes interfered with it.

In particular, for the empty bone deletion case - this was put in because certain MA features result in a bunch of garbage empty game objects being left behind, which needed cleaning up. As such, I want to understand why people want to retain bones, so I can improve the automation here to address that use case, rather than simply disabling this optimization entirely.

@bdunderscore
Copy link
Owner

Also note that this bug only appears to impact Apply on Play mode, so it should still work on upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants