Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization API] Localization Assetを使ってると言語のフォールバックが効かない #100

Closed
anatawa12 opened this issue Dec 27, 2023 · 0 comments · Fixed by #107
Closed

[Localization API] Localization Assetを使ってると言語のフォールバックが効かない #100

anatawa12 opened this issue Dec 27, 2023 · 0 comments · Fixed by #107

Comments

@anatawa12
Copy link
Contributor

https://misskey.niri.la/notes/9l50s4zx5r

API的な感じではなく実装的な話ですが、LocalizationAsset.GetLocalizedStringは対応する値がないとキーがそのまま返ってくるので、Func<string, string> lookupの規約として見つからない場合null返すにするのであればなんかしらの形でラップして上げる必要があると思います
@anatawa12 anatawa12 changed the title Localization Assetを使ってると言語のフォールバックが効かない [Localization API] Localization Assetを使ってると言語のフォールバックが効かない Dec 27, 2023
This was referenced Dec 27, 2023
Merged
Closed
@bdunderscore bdunderscore mentioned this issue Jan 6, 2024
Closed
bdunderscore added a commit that referenced this issue Jan 6, 2024
@bdunderscore
fix: .po file assets don't fall back correctly
2f4c66a 
Fixes: #100
@bdunderscore bdunderscore mentioned this issue Jan 6, 2024
Merged
bdunderscore added a commit that referenced this issue Jan 6, 2024
@bdunderscore
fix: .po file assets don't fall back correctly
916b169 
Fixes: #100
bdunderscore added a commit that referenced this issue Jan 6, 2024
@bdunderscore
fix: .po file assets don't fall back correctly (#107)
7842eac 
Fixes: #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: .po file assets don't fall back correctly bdunderscore/ndmf
1 participant
@anatawa12