Revert "feat: add Owner field to IExtensionContext (#480)" (#483)

This reverts commit 2dcda1b.
bdunderscore · Nov 29, 2024 · b385c81 · b385c81
1 parent 0381958
commit b385c81
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 34 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 ### Removed
+- [#483] Removed `IExtensionContext.Owner` due to compatibility issues.
 
 ### Security
 

diff --git a/Editor/API/BuildContext.cs b/Editor/API/BuildContext.cs
@@ -272,18 +272,10 @@ public void DeactivateExtensionContext(Type t)
                     {
                         var ctx = _activeExtensions[t];
                         Profiler.BeginSample("NDMF Deactivate: " + t);
-
-                        using var scope = ErrorReport.WithContext(ctx);
                         try
                         {
                             ctx.OnDeactivate(this);
                         }
-                        catch (Exception e)
-                        {
-                            // ensure we report the exception while the error report context is set
-                            ErrorReport.ReportException(e);
-                            return;
-                        }
                         finally
                         {
                             Profiler.EndSample();
@@ -373,18 +365,10 @@ public IExtensionContext ActivateExtensionContext(Type ty)
                     if (!_activeExtensions.ContainsKey(ty))
                     {
                         Profiler.BeginSample("NDMF Activate: " + ty);
-
-                        using var scope = ErrorReport.WithContext(ctx);
                         try
                         {
                             ctx.OnActivate(this);
                         }
-                        catch (Exception e)
-                        {
-                            // ensure we report the exception while the error report context is set
-                            ErrorReport.ReportException(e);
-                            return null;
-                        }
                         finally
                         {
                             Profiler.EndSample();

diff --git a/Editor/API/IExtensionContext.cs b/Editor/API/IExtensionContext.cs
@@ -1,6 +1,4 @@
-#nullable enable
-
-using System;
+using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 
@@ -22,12 +20,6 @@ public interface IExtensionContext
         /// </summary>
         /// <param name="context"></param>
         void OnDeactivate(BuildContext context);
-
-        /// <summary>
-        /// Return the plugin owning this extension context. Implementing this API is optional for backwards
-        /// compatibility, but is encouraged as it will provide better error messaging.
-        /// </summary>
-        PluginBase? Owner => null;
     }
 
     internal static class ExtensionContextUtil

diff --git a/Editor/ErrorReporting/ErrorReport.cs b/Editor/ErrorReporting/ErrorReport.cs
@@ -308,15 +308,6 @@ internal IDisposable WithContext(PluginBase thePlugin)
             CurrentContext.Plugin = thePlugin;
             return scope;
         }
-
-        internal IDisposable WithContext(IExtensionContext theExtension)
-        {
-            var scope = new RestoreContextScope(this);
-
-            if (theExtension.Owner != null) CurrentContext.Plugin = theExtension.Owner;
-
-            return scope;
-        }
 
         internal IDisposable WithContextPassName(string name)
         {