fix: more problems with TargetSet invalidation

bdunderscore · Aug 21, 2024 · a9b5c25 · a9b5c25
1 parent 39a7dee
commit a9b5c25
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/Editor/PreviewSystem/ComputeContext.cs b/Editor/PreviewSystem/ComputeContext.cs
@@ -3,6 +3,7 @@
 using System;
 using System.Threading.Tasks;
 using JetBrains.Annotations;
+using UnityEngine;
 
 #endregion
 
@@ -39,7 +40,13 @@ static ComputeContext()
 
         internal ComputeContext(string description)
         {
-            Invalidate = () => _invalidater.TrySetResult(null);
+            Invalidate = () =>
+            {
+#if NDMF_TRACE
+                Debug.Log("Invalidating " + Description);
+#endif
+                _invalidater.TrySetResult(null);
+            };
             OnInvalidate = _invalidater.Task;
             Description = description;
         }

diff --git a/Editor/PreviewSystem/Rendering/TargetSet.cs b/Editor/PreviewSystem/Rendering/TargetSet.cs
@@ -34,12 +34,9 @@ public TargetSet(ImmutableList<IRenderFilter> filters)
                 foreach (var filter in _filters)
                 {
                     if (!filter.IsEnabled(_targetSetContext)) continue;
-
-                    var ctx = new ComputeContext("StageDescriptor for " + filter);
-                    ctx.Invalidates(_targetSetContext);
-
+
                     Profiler.BeginSample("TargetSet.GetTargetGroups[" + filter + "]");
-                    var groups = filter.GetTargetGroups(ctx);
+                    var groups = filter.GetTargetGroups(_targetSetContext);
                     if (groups.IsEmpty) continue;
 
                     builder.Add(new Stage