feat: change default yaml flow style to False #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 97.13% 97.16% +0.02%
==========================================
Files 12 12
Lines 873 882 +9
Branches 8 8
==========================================
+ Hits 848 857 +9
Misses 23 23
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
The change looks good. Can you add a test case for this change? |
|
I'm currently in vacation. I'll revisit this PR after 18th. |
The default flow style is hard to read for non-trivial system configurations. Signed-off-by: ZHANG Yuntian <[email protected]>
|
Finally got time around for this one again. @bdrung please take a look. |
bdrung
reviewed
Apr 2, 2024
Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
|
Thanks. |
bdrung
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default flow style is hard to read for non-trivial system configurations.
Here is how different flow style looks like.
This is a real output we are currently generating with bdebstrap, which is hard to read: config.yaml.txt
Readability is important because we have customers who want to customize our systems. In the past we have to teach them how to use our build system, but we plan to just let them make changes to the generated
config.yamland build it.Extension name changed to pass GitHub upload rule.