Julia: update benchmark code #178
Open
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving numbers to the type-level allows Julia to effectively memoize via its dispatch system and constant propagation. Removing this implicit memoization makes the implementation match the others in the benchmark. As proof, calling "@code_native"" on "fibonacci(Val(10))" gives the results below with the result value of 55 memoized: .text .file "fibonacci" .globl julia_fibonacci_9798 # -- Begin function julia_fibonacci_9798 .p2align 4, 0x90 .type julia_fibonacci_9798,@function julia_fibonacci_9798: # @julia_fibonacci_9798 ; Function Signature: fibonacci(Base.Val{10}) ; ┌ @ In[21]:7 within `fibonacci` \# %bb.0: # %top push rbp mov rbp, rsp mov eax, 55 pop rbp ret .Lfunc_end0: .size julia_fibonacci_9798, .Lfunc_end0-julia_fibonacci_9798 ; └ # -- End function .section ".note.GNU-stack","",@progbits
Encapsulating the code in a function allows it to be compiled. The basic compilation unit in Julia is a function, so any code at the top level is not compiled. "@inbounds" macros were removed as they didn't make a difference for performance in this case. All other changes were stylistic to make the code more idiomatic.
bddicken
reviewed
Dec 6, 2024
| fibonacci(::Val{1}) = 1 | ||
| # general case | ||
| fibonacci(::Val{n}) where n = fibonacci(Val(n-1)) + fibonacci(Val(n-2)) | ||
| fibonacci(n) = n < 2 ? n : fibonacci(n-1) + fibonacci(n-2) |
There was a problem hiding this comment.
This needs to go back to having an if / case for 0 and 1.
There was a problem hiding this comment.
Is (n == 0 || no == 1) ? n : fibonacci(n-1) + fibonacci(n-2) okay, or does it need to be the full
n == 0 ? 0 :
n == 1 ? 1 :
fibonacci(n-1) + fibonacci(n-2)
bddicken
reviewed
Dec 6, 2024
| main(u) = println(sum(fibonacci, 1:u)) |
There was a problem hiding this comment.
Can you explain if / how this is equivalent to the loop?
There was a problem hiding this comment.
The sum function just calls mapreduce with addition as the reducing function. So this is equivalent to mapping fibonacci to all elements in the range from 1 to u and then adding them up.
If you're prioritizing making the implementations more uniform between languages rather than using more idiomatic language constructs, going back to a loop is just fine. Let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see each commit message for justification.